Metal backend: fix bugs in qmv_impl #17188
Open
+53
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two bugs in
qmv_impl(also submitted PR 3096 to MLX)Fix 1: Changed
qdottoqdot_safewhen handling remaining elements in theN < 8caseNotice that in
qmv_impl, there are two code paths based on whetherN < 8:N >= 8: Correctly usesqdot_safefor remaining elementsN < 8: Incorrectly usedqdotinstead ofqdot_safefor remaining elements (fixed in this PR)Fix 2: Changed
in_vec_size_gfrom floor division to ceiling division to correctly handle cases whereKis not a multiple of group size