Fix KeyError in InsertIOQDQ pass for LLM quantization #17194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a
KeyErrorin the InsertIOQDQ pass that occurrs when quantizing LLMs (such as SmolLM2) for the Qualcomm QNN backend.Problem
In insert_io_qdq.py, the
q_dq_mapdictionary was missing entries for dequantize operations. When a node's quantization encoding was already a dequantize operation (e.g.,dequantize_per_tensor.default), trying to look it up in the map during the _insert phase caused aKeyError.Solution
Extended the
q_dq_mapto include dequantize-to-self (identity) mappings for:quantized_decomposed.dequantize_per_tensor.defaultquantized_decomposed.dequantize_per_tensor.tensorquantized_decomposed.dequantize_per_channel.defaultThis allows the pass to correctly handle nodes that have already been processed into dequantized form.
Testing
astmodule.q_dq_mapnow contains the expected 6 keys.Fixes Qualcomm Quantization and Lowering for LLM fails #16690