ST7565 - Only render if the display is active. #25962
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
Jan 23, 2026
zvecr
requested changes
Jan 23, 2026
|
|
||
| void st7565_render(void) { | ||
| if (!st7565_initialized) { | ||
| if (!st7565_initialized || !st7565_active) { |
Member
There was a problem hiding this comment.
This will break the existing behaviour of "writing to the display when its timed out, will turn back on the display".
Author
There was a problem hiding this comment.
other code probably shouldn't be relying on that side-effect.
suggest we find occurences of this and call some method to activate the display prior to writing to it where this happens.
e.g. (psuedo-code)
st7565_setActive();
st7565_write(...);
do you know where this behavior relied upon in the codebase?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ST7565 - Only render if the display is active.
If the display is off, no-need to render, just wastes power and cpu-cycles. Also prevents accidental use the LCD when not active.
Types of Changes
Issues Fixed or Closed by This PR
Checklist