Handle split keyboard watchdog and os detection resets in a unified way. #25964
+38
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pre_mcu_reset_useris executed before a reset.Additionally, I've taken similar approaches in other firmware that I'm a maintainer or author of, it allows graceful shutdown in a single place.
Types of Changes
Issues Fixed or Closed by This PR
It allowed me to hook into the reset code and set the backlight color on an ErgodoxInfinity, and also to update the display with the reason prior to the reset. It was invaluable for debugging.
Checklist