Skip to content

Jan 2026 dependencies bump#1787

Merged
mpharrigan merged 4 commits intomainfrom
2026-01/deps
Jan 12, 2026
Merged

Jan 2026 dependencies bump#1787
mpharrigan merged 4 commits intomainfrom
2026-01/deps

Conversation

@mpharrigan
Copy link
Collaborator

@mpharrigan mpharrigan commented Jan 6, 2026

  • bump dependencies to latest versions that form a mutually-compatible set with pip-compile.
  • Latest sympy no longer re-exports the symbols we use in sympy_to_proto.py, so I added the imports.
  • Mypy/Numpy is getting pickier about NDArary[cirq.Qid] and friends. Added # type: ignore and opened NDArray[MyObject] type annotations are not allowed #1789 to track longer-term fix

@mpharrigan mpharrigan requested a review from mhucka January 6, 2026 19:57
@mpharrigan
Copy link
Collaborator Author

Opened #1789 to track the growing complaints with e.g. NDArray[cirq.Qid] in type annotations

Copy link
Contributor

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks overall okay, but it seems to mix multiple kinds of changes into one PR:

  1. Dependency version updates in the various requirements files
  2. Addition of type annotations
  3. In the case of qualtran/serialization/sympy_to_proto.py, addition of imports

It's not immediately clear whether these are actually related and need to be in the same PR. If they do need to be in the same CL, could the reasons be explained in the PR description?

Conversely, if they don't need to be in the same CL, I would recommend following the principle of small CLs (https://google.github.io/eng-practices/review/developer/small-cls.html) and splitting this up into separate PRs.

(I hope this doesn't come across as too critical. Just trying to do a good review.)

@mpharrigan
Copy link
Collaborator Author

should have noted that those changes are in response to new mypy and pylint failures that only occur with the updated dependency versions. will update pr description

Copy link
Contributor

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpharrigan mpharrigan enabled auto-merge (squash) January 12, 2026 18:29
@mpharrigan mpharrigan merged commit f17ce8d into main Jan 12, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants