Skip to content

fix(ui): QInput shadow-text is showing when input is out of focus but hasError (#17155)#18164

Open
IceIsFrozen wants to merge 1 commit intoquasarframework:devfrom
IceIsFrozen:fix-qinput-shadow-text
Open

fix(ui): QInput shadow-text is showing when input is out of focus but hasError (#17155)#18164
IceIsFrozen wants to merge 1 commit intoquasarframework:devfrom
IceIsFrozen:fix-qinput-shadow-text

Conversation

@IceIsFrozen
Copy link

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

Other information:

Since errors were treated the same as focus for the highlighted class in use-field.js

+ (hasError.value === true || state.focused.value === true ? ' q-field--highlighted' : '')

made a simple change for the shadow-text/focused situation by splitting off for focused and checking if there's an error. If not, shadow-text acts normally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant