fix(a11y): add aria-label to QTable records-per-page QSelect (#18170)#18180
Open
vamsi2246 wants to merge 1 commit intoquasarframework:devfrom
Open
fix(a11y): add aria-label to QTable records-per-page QSelect (#18170)#18180vamsi2246 wants to merge 1 commit intoquasarframework:devfrom
vamsi2246 wants to merge 1 commit intoquasarframework:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #18170, which reported that the QTable pagination "Records per page" dropdown lacked an accessibility label.
The
QSelectused for selecting the number of rows per page was missing anaria-label, causing screen readers to announce it incorrectly and failing WCAG accessibility requirements.What was changed
Added the following property to the QSelect inside
getPaginationDiv()inui/src/components/table/QTable.js:This ensures:
rowsPerPageLabel, it becomes the aria-label.$q.lang.table.recordsPerPage).Impact
Testing
Tested locally in the Quasar dev environment and confirmed that the rendered HTML now includes:
This resolves the accessibility issue.