Conversation
quickfixj-core/src/main/java/quickfix/mina/initiator/AbstractSocketInitiator.java
Show resolved
Hide resolved
chrjohn
left a comment
There was a problem hiding this comment.
Please roll back the import changes.
done. out of curiosity - is the intention that we only import the classes that are required and not the whole package because importing is a compile time task and I don't think it has any latency implications. |
The intention is simply that one uses IntelliJ, another uses Eclipse, a third Netbeans and either has its own taste of how imports should be organized (unless you configure it the same for all IDEs). |
Got it. Thanks I've reverted the import changes. I didn't get much time after this initial one where my changes were around non-critical execution path which were called once maybe twice in the life cycle |
|
@abhishekraha thanks for your PR! 👍 |
Changes :