Populate Text(58) field when rejectMessageOnUnhandledException=true#851
Open
mgatny wants to merge 1 commit intoquickfix-j:masterfrom
Open
Populate Text(58) field when rejectMessageOnUnhandledException=true#851mgatny wants to merge 1 commit intoquickfix-j:masterfrom
Text(58) field when rejectMessageOnUnhandledException=true#851mgatny wants to merge 1 commit intoquickfix-j:masterfrom
Conversation
Text(58) field when rejectMessageOnUnhandledException=true
Member
|
@mgatny thanks for the PR. |
ca0e9d8 to
c635430
Compare
If rejectMessageOnUnhandledException=true and an unhandled exception is thrown from the fromCallback(), include the exception message in the Text(58) field of the resulting Reject or BusinessMessageReject.
c635430 to
7a654ea
Compare
Member
|
@mgatny any comments on my proposal? Thank you |
Author
|
@chrjohn here's what I'm thinking:
This would allow users to get exactly what they want in Text(58), but still give them the ability to filter. And it will not change any behavior for anyone already using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #667
refs #639
If rejectMessageOnUnhandledException=true and an unhandled exception is thrown from the fromCallback(), include the exception message in the Text(58) field of the resulting Reject or BusinessMessageReject.