Allow using middleware with custom configuration#647
Closed
franzliedke wants to merge 1 commit intorack:mainfrom
Closed
Allow using middleware with custom configuration#647franzliedke wants to merge 1 commit intorack:mainfrom
franzliedke wants to merge 1 commit intorack:mainfrom
Conversation
Collaborator
|
Hi @franzliedke I think this one would be solved by #442 , right? |
Author
|
@santib Yes, totally! Looks like I only got through the first half of the PR list. 😇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far, the documentation is suggesting 100% global configuration for what's essentially a middleware. I do wonder whether there are any reasons not to support passing in a configuration directly wherever I am adding a middleware to my stack. (This could be a base controller with per-controller middleware.)
Pseudo-code example:
Primarily, this would let me avoid mixing filters (for request type and path) with the discriminator block - I'd rather keep the filtering to my middleware builder.
Let me know what you think about this idea, and especially what may speak against this. Then I'm happy to send a "real" pull request with tests etc.