Use string keys in example for Deserialization#2385
Open
wasabigeek wants to merge 2 commits intorails-api:0-10-stablefrom
Open
Use string keys in example for Deserialization#2385wasabigeek wants to merge 2 commits intorails-api:0-10-stablefrom
wasabigeek wants to merge 2 commits intorails-api:0-10-stablefrom
Conversation
Member
|
great! could you also include the following changes: @@ -59,6 +59,7 @@ module ActiveModelSerializers
# # {
# # title: 'Title 1',
# # date: '2015-12-20',
+ # # id: 1,
# # author_id: 2,
# # second_author_id: nil
# # comment_ids: [3, 4]on line 62, and @@ -70,8 +71,8 @@ module ActiveModelSerializers
# # {
# # title: 'Title 1',
# # published_at: '2015-12-20',
- # # author_id: '2',
- # # author_type: 'people'
+ # # author_id: 2,
+ # # author_type: 'User'
# # }
#
def parse!(document, options = {})on lines 73/74 |
Author
|
Done! Noob question, how did you paste the diffs? And should I be worried about the Appveyor failures? |
Member
opening 3 backticks are followed by
NO for any of the current failures (travis/appveyor), as we still have some other CI issues to resolve |
Author
|
Fancy, didn’t know the diff coloration came built in. Ok great, let me know if there’s anything else i should change here :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2384