Add <mark> to DEFAULT_ALLOWED_TAGS#180
Merged
flavorjones merged 1 commit intorails:mainfrom Apr 23, 2024
Merged
Conversation
flavorjones
approved these changes
Apr 22, 2024
Member
flavorjones
left a comment
There was a problem hiding this comment.
This seems reasonable to me.
At some point we should audit the differences between Loofah and R::H::S, because Loofah has allowed this tag since v2.0.0 in 2014.
Contributor
Author
|
Maybe a PR to DRY up the code? |
Member
|
@dogweather I want to audit the differences before writing code, I started doing this for attribute in #136 and hope to finish unifying Loofah and R::H::S as much as possible for the next big release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a safe tag and a common use case for
sanitizein Rails: It's a semantic tag that's useful when showing search results. Search results can contain user input. Hence, best practice is to run them throughsanitize.E.g., in my code: