Skip to content

Comments

Add dependency on minitest-mock for MT6 compatibility#211

Open
voxik wants to merge 1 commit intorails:mainfrom
voxik:MT6
Open

Add dependency on minitest-mock for MT6 compatibility#211
voxik wants to merge 1 commit intorails:mainfrom
voxik:MT6

Conversation

@voxik
Copy link

@voxik voxik commented Jan 15, 2026

This prevents test errors with minitest 6+ such as:

  1) Error:
RailsApiTest#test_best_supported_vendor_when_html5_is_not_supported_returns_html4: NoMethodError: undefined method 'stub' for class Rails::HTML::Sanitizer
    test/rails_api_test.rb:21:in 'RailsApiTest#test_best_supported_vendor_when_html5_is_not_supported_returns_html4'

  2) Error:
RailsApiTest#test_best_supported_vendor_when_html5_is_supported_returns_html5: NoMethodError: undefined method 'stub' for class Rails::HTML::Sanitizer
    test/rails_api_test.rb:29:in 'RailsApiTest#test_best_supported_vendor_when_html5_is_supported_returns_html5'

This is due to minitest-mock being extracted from Minitest 6+:

minitest/minitest@de9aac1

Please note that the condition is in this way, because MT6 restrict upport to Ruby 3.2+ [1, 2]

@voxik
Copy link
Author

voxik commented Jan 15, 2026

Please see https://github.com/rails/rails-html-sanitizer/actions/runs/20606018257 for examples of the test failures

This prevents test errors with minitest 6+ such as:

~~~
  1) Error:
RailsApiTest#test_best_supported_vendor_when_html5_is_not_supported_returns_html4:
NoMethodError: undefined method 'stub' for class Rails::HTML::Sanitizer
    test/rails_api_test.rb:21:in 'RailsApiTest#test_best_supported_vendor_when_html5_is_not_supported_returns_html4'

  2) Error:
RailsApiTest#test_best_supported_vendor_when_html5_is_supported_returns_html5:
NoMethodError: undefined method 'stub' for class Rails::HTML::Sanitizer
    test/rails_api_test.rb:29:in 'RailsApiTest#test_best_supported_vendor_when_html5_is_supported_returns_html5'
~~~

This is due to minitest-mock being extracted from Minitest 6+:

minitest/minitest@de9aac1

Please note that the condition is in this way, because MT6 restrict
upport to Ruby 3.2+ [[1], [2]]

[1]: minitest/minitest-mock#4
[2]: minitest/minitest#1058
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant