fix: migrate from NPM_CONFIG_PRODUCTION to NPM_CONFIG_OMIT#369
Draft
iloveitaly wants to merge 5 commits intorailwayapp:mainfrom
Draft
fix: migrate from NPM_CONFIG_PRODUCTION to NPM_CONFIG_OMIT#369iloveitaly wants to merge 5 commits intorailwayapp:mainfrom
iloveitaly wants to merge 5 commits intorailwayapp:mainfrom
Conversation
Replace the deprecated NPM_CONFIG_PRODUCTION environment variable with NPM_CONFIG_OMIT=dev,optional for exact parity with previous behavior. Changes: - Remove --omit=dev flag from npm prune command - Set NPM_CONFIG_OMIT=dev,optional in prune step instead of NPM_CONFIG_PRODUCTION=true - This approach uses environment variables as recommended The new approach: - Omits devDependencies (via "dev") - Omits optionalDependencies (via "optional") - Maintains NODE_ENV=production for lifecycle scripts This provides exact behavioral parity with the old NPM_CONFIG_PRODUCTION=true approach while using the modern npm configuration method.
iloveitaly
force-pushed
the
claude/npm-omit-migration-01TxuroycdoHafSVazyMibFN
branch
from
072d9af to
c66c64b
Compare
iloveitaly
changed the title
Remove stderrAllowed from node examples that no longer need it after migrating from NPM_CONFIG_PRODUCTION to NPM_CONFIG_OMIT. The deprecated NPM_CONFIG_PRODUCTION flag was causing npm warnings that required stderr to be allowed. Affected examples: - node-npm - node-prisma - node-remix - node-latest-npm-native-deps - node-npm-install-in-build - node-oldest Examples that keep stderrAllowed have legitimate reasons: - node-bun/node-bun-no-deps: Bun routes console.log/error to stderr - node-tanstack-start: Framework outputs to stderr during startup
Remove NPM_CONFIG_PRODUCTION=false from the GetNodeEnvVars function used during install and runtime. This deprecated config option was causing npm warnings even when set to false. Changes: - Remove NPM_CONFIG_PRODUCTION from node environment variables - Update documentation to reflect removed variable - npm's default behavior is to install all dependencies, which is what we want The complete migration from NPM_CONFIG_PRODUCTION is now: - Install step: No NPM_CONFIG_PRODUCTION (installs all deps by default) - Prune step: NPM_CONFIG_OMIT=dev,optional (removes dev and optional deps)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the deprecated NPM_CONFIG_PRODUCTION environment variable with NPM_CONFIG_OMIT=dev,optional for exact parity with previous behavior.