Open
Conversation
added 3 commits
May 24, 2021 14:13
kevinwl02
suggested changes
Jun 1, 2021
| /// - Parameters: | ||
| /// - title: The LocalizedStringKey of right part text of the label | ||
| /// - icon: The visual representation of left part image of the label | ||
| @available(iOS 14.0, *) |
Contributor
There was a problem hiding this comment.
Why are these 3 inits iOS14 available? I think you should be able to remove this constraint.
| private func setupView(_ view: UIStackView, context: Context) { | ||
| guard let labelStyleType = context.viewValues?.labelStyle?.labelStyleType else { return } | ||
|
|
||
| context.viewOperationQueue.addOperation { |
Contributor
There was a problem hiding this comment.
It's not necessary to use the operation queue in this case.
Note: The operation queue main purpose is to flatten view hierarchy updates that would add strain to the call stack causing potential stack overflows. Usually this is used when you want to call updateView of children views.
|
|
||
| public func createView(context: Context) -> UIView { | ||
| let hstack = HStack { | ||
| Spacer() |
Contributor
There was a problem hiding this comment.
It seems this view always expands horizontally and always centered. Please confirm this behavior.
kevinwl02
suggested changes
Jun 1, 2021
| import UIKit | ||
|
|
||
| @available(iOS 14.0, *) | ||
| public typealias LocalizedStringKey = String |
Contributor
There was a problem hiding this comment.
I think you can remove the constraint for this typealias
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implement ios 14 Label
https://developer.apple.com/documentation/swiftui/label