Skip to content

Fixed the timing of updating the text binding on SwiftUITextField #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexTanabe wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed the timing of updating the text binding on SwiftUITextField #89

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4192e24
Fixed the timing of updating the text binding on SwiftUITextField
TanabeRx Jun 27, 2022
a9a4006
Remove unnecessary logic and avoided sending consecutive text change …
TanabeRx Jun 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 14 additions & 15 deletions Sources/AltSwiftUI/Source/UIKitViews/UIKitControls.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,9 @@ class SwiftUITextField<T>: UITextField, UITextFieldDelegate, UIKitViewHandler {
init() {
super.init(frame: .zero)
self.delegate = self

addTarget(self, action: #selector(Self.textFieldDidChange(_:)), for: .editingChanged)

setupView()
}
required init?(coder: NSCoder) {
Expand All @@ -107,6 +110,10 @@ class SwiftUITextField<T>: UITextField, UITextFieldDelegate, UIKitViewHandler {
setContentCompressionResistancePriority(.defaultLow, for: .horizontal)
}
private func setBindingText(_ text: String) {
guard lastWrittenText != text else { return }

lastWrittenText = textBinding?.wrappedValue ?? ""

if let value = value, let formatter = formatter {
var object: AnyObject?
formatter.getObjectValue(&object, for: text, errorDescription: nil)
Expand All @@ -124,28 +131,20 @@ class SwiftUITextField<T>: UITextField, UITextFieldDelegate, UIKitViewHandler {
onCommit?()
return true
}

func textFieldDidBeginEditing(_ textField: UITextField) {
firstResponder?.wrappedValue = true
onEditingChanged?(true)
}
func textFieldDidEndEditing(_ textField: UITextField, reason: UITextField.DidEndEditingReason) {
// ios 12 will not call shouldChangeCharactersIn func when select word candidate.
// so make sure update binding text here
if let text = text, textBinding?.wrappedValue != text {
lastWrittenText = text
setBindingText(text)
}

firstResponder?.wrappedValue = false
onEditingChanged?(false)
}
func textField(_ textField: UITextField, shouldChangeCharactersIn range: NSRange, replacementString string: String) -> Bool {
let newText = (textField.text as NSString?)?.replacingCharacters(in: range, with: string)
if let text = newText, textBinding?.wrappedValue != text {
lastWrittenText = text
setBindingText(text)
}
return textBinding?.wrappedValue == newText

// MARK: Text change handling

@objc func textFieldDidChange(_ textField: UITextField) {
setBindingText(textField.text ?? "")
}
}

Expand Down Expand Up @@ -246,7 +245,7 @@ class SwiftUISegmentedControl: UISegmentedControl, UIKitViewHandler {

@objc private func valueChanged() {
selectionBinding.wrappedValue = selectedSegmentIndex
}
}
}

class SwiftUIDatePicker: UIDatePicker, UIKitViewHandler {
Expand Down