Remove restriction on amplitude-js version#372
Open
gugu wants to merge 1 commit intorangle:masterfrom
Open
Conversation
NPM v7 currently returns this error on installation: ``` npm ERR! code ERESOLVE npm ERR! ERESOLVE unable to resolve dependency tree npm ERR! npm ERR! While resolving: shortcm_frontend_account@1.0.0 npm ERR! Found: amplitude-js@7.4.4 npm ERR! node_modules/amplitude-js npm ERR! amplitude-js@"^7.4.1" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer amplitude-js@"^4.1.0" from @redux-beacon/amplitude@1.0.3 npm ERR! node_modules/@redux-beacon/amplitude npm ERR! @redux-beacon/amplitude@"^1.0.3" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry npm ERR! this command with --force, or --legacy-peer-deps npm ERR! to accept an incorrect (and potentially broken) dependency resolution. npm ERR! npm ERR! See /home/kostenko/.npm/eresolve-report.txt for a full report. npm ERR! A complete log of this run can be found in: npm ERR! /home/kostenko/.npm/_logs/2021-08-15T09_55_07_290Z-debug.log ``` I don't think there is a need a strict version check for amplitude-js version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NPM v7 currently returns this error on installation:
I don't think there is a need a strict version check for amplitude-js version
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
What was done
...Describe the fix you made, the feature you built, or the documentation you added
Associated Issues
❤️ Thanks
Thanks for taking the time to help out with the project, it's much appreciated 🙂