Open
Conversation
Owner
|
This looks pretty good, and I'm inclined to merge it. Before I do, I want to be sure you understand that HHEA is one of (at least) 3 sets of metrics tables. The vertical metrics page at Glyphs has lots more information on this. Perhaps this means a change to doc comments or method names to emphasize that this is the HHEA value and not the definitive value for such metrics. |
Author
|
Thank you, your site was really instructive. I knew those values weren't definitive, but I didn't know it was this much of a mess. I'm adding doc comments right away ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsing the hhea table, to get some general information about the font :
As I understand it, this is needed to get the distance between two baselines (MaxAscent + MaxDescent + LineGap)