Cleanup duplicated code in hybrid scan#21353
Merged
rapids-bot[bot] merged 4 commits intorapidsai:mainfrom Feb 6, 2026
Merged
Conversation
mhaseeb123
commented
Feb 5, 2026
| return {std::move(expr_conv), std::move(output_dtypes)}; | ||
| } | ||
|
|
||
| void hybrid_scan_reader_impl::prepare_materialization(read_columns_mode read_columns_mode, |
Member
Author
There was a problem hiding this comment.
Open to suggestions for names of these two helpers.
mhaseeb123
commented
Feb 5, 2026
| * @param stream CUDA stream used for device memory operations and kernel launches | ||
| * @param mr Device memory resource used to allocate the returned column's device memory | ||
| */ | ||
| void initialize_options(cudf::host_span<std::vector<size_type> const> row_group_indices, |
Member
Author
There was a problem hiding this comment.
We only ever need row_group_indices.size() in here so just directly take in num_sources
mhaseeb123
added
3 - Ready for Review
mhaseeb123
changed the title
davidwendt
approved these changes
Feb 5, 2026
mhaseeb123
added
the
improvement
mhaseeb123
added
4 - Needs Review
bdice
approved these changes
Feb 6, 2026
vuule
approved these changes
Feb 6, 2026
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up the hybrid scan reader implementation by moving duplicated code into helper functions. No code logic has been changed.
Checklist