Conversation
kimballh
requested changes
Dec 8, 2022
Contributor
kimballh
left a comment
kimballh
left a comment
There was a problem hiding this comment.
I ran the tests on plot and had to tweak a few things. I guess in some places, the macro gets a list of strings which screws things up. This passed all the tests though.
In the same pr that updates RasgoTransforms in the API, we will also need to remove the import statement from the select_top_rows_cte.sql template.
kimballh
approved these changes
Dec 9, 2022
Contributor
kimballh
left a comment
kimballh
left a comment
There was a problem hiding this comment.
Glad I ran the tests again, forgot a space, but I pushed that tiny change and I think it's good to ship now! Don't forget to bump the version.
…ce/RasgoTransforms into filters-function
…ce/RasgoTransforms into filters-function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the filters macros into global functions