-
Notifications
You must be signed in to change notification settings - Fork 13
feat: migrate scroll-area to base ui #572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThe scroll-area component is being refactored to remove the 'auto' type option and replace it with 'hover' as the default. The ScrollAreaRoot component is consolidated into a new primary ScrollArea component, and documentation and tests are updated to reflect the API changes. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
Description
Breaking Changes
typeprop options changed from'auto' | 'always' | 'scroll' | 'hover'to'always' | 'hover' | 'scroll'autotohoverChanges
Import from
@base-ui/reactinstead ofradix-uiImplemented style changes with Base UI's data attributes:
Docs & Tests
Updated tests for new type options and default
Updated props documentation with new type values
Summary by CodeRabbit
New Features
classNameandstyleprops to ScrollArea for enhanced customization.Bug Fixes
autotype option; ScrollArea now supportsalways,hover, andscrolltypes only.autotohover.Documentation