Skip to content

feat: migrate Sheet to Base UI #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rohanchkrabrty wants to merge 3 commits into
base: base-popover
Choose a base branch
from
Open

feat: migrate Sheet to Base UI #582

rohanchkrabrty wants to merge 3 commits into from

Conversation

@rohanchkrabrty
Copy link
Contributor

@rohanchkrabrty rohanchkrabrty commented Feb 4, 2026

Description

Breaking Changes

  • close prop renamed to showCloseButton — defaults to true (previously false)
  • asChild prop removed from Sheet.Trigger

Changes

  • Migrated Sheet component from Radix UI Dialog to Base UI Dialog primitives
  • Replaced keyframe animations with CSS transitions using Base UI's data-starting-style and data-ending-style attributes
  • Updated CSS to use Base UI data attributes:
  • Added overlayProps prop to customize backdrop/overlay behavior

Docs & Tests

  • Updated documentation to reflect Base UI Dialog API and new component structure
  • Updated all demo examples to use Sheet.Header, Sheet.Body, and Sheet.Footer
  • Updated props documentation with Base UI-specific props
  • Fixed all 19 tests to work with Base UI's component structure

@rohanchkrabrty rohanchkrabrty self-assigned this Feb 4, 2026
@vercel
Copy link

vercel bot commented Feb 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
apsara Ready Ready Preview, Comment Feb 4, 2026 4:15am

@rohanchkrabrty rohanchkrabrty changed the title feat: migrate Dialog to Base UI feat: migrate Sheet to Base UI Feb 4, 2026
@rohanchkrabrty rohanchkrabrty changed the base branch from main to base-accordion February 4, 2026 04:17
@rohanchkrabrty rohanchkrabrty changed the base branch from base-accordion to base-popover February 4, 2026 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rsbh rsbh Awaiting requested review from rsbh

@paanSinghCoder paanSinghCoder Awaiting requested review from paanSinghCoder

Assignees

@rohanchkrabrty rohanchkrabrty

Labels

Do not merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rohanchkrabrty