Skip to content

feat: migrate Popover to Base UI #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rohanchkrabrty wants to merge 1 commit into
base: base-accordion
Choose a base branch
from
Open

feat: migrate Popover to Base UI #584

rohanchkrabrty wants to merge 1 commit into from

Conversation

@rohanchkrabrty
Copy link
Contributor

@rohanchkrabrty rohanchkrabrty commented Feb 4, 2026 •
edited
Loading

Description

Changes

  • Migrated from Radix UI to Base UI (@base-ui/react)
  • Updated styling: separate popoverPositioner class for positioning wrapper

Docs & Tests

  • Updated all tests: positioning attributes now checked on positioner element, not popup
  • Removed aria-label related tests
  • Updated props documentation: removed ariaLabel and avoidCollisions, added new Base UI props
  • Removed redundant accessibility documentation section

@rohanchkrabrty rohanchkrabrty self-assigned this Feb 4, 2026
@vercel
Copy link

vercel bot commented Feb 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
apsara Ready Ready Preview, Comment Feb 4, 2026 4:19am

@rohanchkrabrty rohanchkrabrty changed the base branch from main to base-accordion February 4, 2026 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rohilsurana rohilsurana rohilsurana approved these changes

@paanSinghCoder paanSinghCoder Awaiting requested review from paanSinghCoder

@rsbh rsbh Awaiting requested review from rsbh

Assignees

@rohanchkrabrty rohanchkrabrty

Labels

Do not merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rohanchkrabrty @rohilsurana