feat: export Invoices page as a component and consume it in apps/admin#1357
Open
paanSinghCoder wants to merge 12 commits intorefactor/admin-ui-childfrom
Open
feat: export Invoices page as a component and consume it in apps/admin#1357paanSinghCoder wants to merge 12 commits intorefactor/admin-ui-childfrom
paanSinghCoder wants to merge 12 commits intorefactor/admin-ui-childfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Pull Request Test Coverage Report for Build 21629889516Details
💛 - Coveralls |
…ctionality in admin UI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@raystack/frontier/adminapps/admin/src/pages/invoices/list/intoweb/lib/admin/views/invoices/as a router-agnostic page.@raystack/frontier/adminwith optional prop:appName.lib/adminshared pieces: utils (connect-pagination, transform-query, connect-timestamp with isNullTimestamp), components (PageTitle, etc.) and CSS modules.pages/invoices/listfrom the app; Invoices is implemented in the lib.pagination/queryutils from the lib so existing app pages (org list/details, users list, audit logs, etc.) import them from@raystack/frontier/admininstead of ~/utils/....Note: For local testing, use "@raystack/frontier": "workspace:^" in frontier/web/apps/admin/package.json.
Technical details
lib/admin/views/invoices/(index, columns, navbar, invoices.module.css).InvoicesPageWithRouterinapps/admin/src/pages/invoices/, route /invoices; Sidebar uses~/assets/icons/invoices.svg.Test plan