Fixes a bug in the watch priority sorting algorithm.#764
Open
mpforce1 wants to merge 1 commit intordavydov:masterfrom
Open
Fixes a bug in the watch priority sorting algorithm.#764mpforce1 wants to merge 1 commit intordavydov:masterfrom
mpforce1 wants to merge 1 commit intordavydov:masterfrom
Conversation
|
@rdavydov its working again 👍 |
9 tasks
7 tasks
|
Is it working well right now? |
Author
It's been a while since I looked at this branch specifically but I believe it was working as of December. FYI, I've been working on a revamped version of the priority system that's easier to test over on my fork. @saabia's been helping me test it and we seem to be in a good place now. This is on my |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a regression introduced in the last update (sorry 🙏 ).
Fixes #748 (again)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I stripped out just the sorting part and ran some local tests to find the issue. Once fixed, I reran the tests and found it sorted as expected.
Checklist: