Improve instructions to integrate into a create-react-app app#52
Open
gnapse wants to merge 1 commit intoreact-toolbox:masterfrom
gnapse:patch-1
Open
Improve instructions to integrate into a create-react-app app#52gnapse wants to merge 1 commit intoreact-toolbox:masterfrom gnapse:patch-1
create-react-app app#52gnapse wants to merge 1 commit intoreact-toolbox:masterfrom
gnapse:patch-1
Conversation
* Moves the generated asset files into `src/` because you can't normally import from outside it. * Adds the import of the `theme.css` file, which is absolutely needed for this integration to work. * Minor couple of fixes.
|
Were you able to get it working with CRA 1.3.1 with the example code? Specifically, this isn't working for me: It gives me the error: |
Author
|
At a glance I think that does not have to do with my changes. The error you mention above is due to |
Author
|
Hello? |
|
Just made a new react app using CRA and toolbox, this PR had the only steps missing to make integration flawless today. Would love to see this merged 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/because you can't normally import from outside it.theme.cssfile, which is absolutely needed for this integration to work.These are based on my experience while trying to follow the instructions to integrate
react-toolboxinto a React app created withcreate-react-app. Especially the missing line importing thetheme.cssfile was daunting for a few minutes, and almost made me quit and look for alternatives.