This repository was archived by the owner on Sep 22, 2022. It is now read-only.
Open
Conversation
Signed-off-by: Akarshit Wal <akarshitwal@gmail.com>
Signed-off-by: Alvaro Bueno <alvaro.bueno@mailchimp.com>
Signed-off-by: Alvaro Bueno <alvaro.bueno@mailchimp.com>
Signed-off-by: Alvaro Bueno <alvaro.bueno@mailchimp.com>
Collaborator
|
@Akarshit Can you revisit this PR and get it working? We need some tests on this plugin working. |
brent-hoover
suggested changes
Feb 14, 2022
Collaborator
brent-hoover
left a comment
brent-hoover
left a comment
There was a problem hiding this comment.
Both build and tests are failing here
| command: | | ||
| sudo apt-get install -y mongodb | ||
| mongo --eval "rs.initiate()" | ||
| npx --quiet --package @reactioncommerce/ci-scripts@1.12.2 run-integration-tests |
Collaborator
There was a problem hiding this comment.
I think this command runs all integration tests, not just the ones in this plugin
Contributor
Author
|
This same config files seems to work on other api-plugins and fails on this one. Will return to fix this later. |
Signed-off-by: Mohan Narayana <mohan.narayana@mailchimp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Currently there are no integration tests to check a plugin update with the reaction version
Solution
This PR adds a circle CI step that runs the integration tests on the plugin.
Breaking changes
None expected
Testing