Refactor model namespaces and update imports#362
Merged
glennawatson merged 1 commit intomainfrom Jan 12, 2026
Merged
Conversation
Moved several model classes from 'ReactiveUI.SourceGenerators.Input.Models', 'ReactiveUI.SourceGenerators.Reactive.Models', and 'ReactiveUI.SourceGenerators.ObservableAsProperty.Models' to 'ReactiveUI.SourceGenerators.Models'. Updated all related using statements and namespace declarations to reflect this change. Also updated references to RxSchedulers in ReactiveCommandGenerator for clarity and global namespace usage. This improves code organization and consistency across source generators.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #362 +/- ##
=======================================
Coverage 43.22% 43.22%
=======================================
Files 64 64
Lines 3646 3646
Branches 420 420
=======================================
Hits 1576 1576
Misses 1950 1950
Partials 120 120 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fixes #351
What is the current behavior?
#351
What is the new behavior?
Moved several model classes from 'ReactiveUI.SourceGenerators.Input.Models', 'ReactiveUI.SourceGenerators.Reactive.Models', and 'ReactiveUI.SourceGenerators.ObservableAsProperty.Models' to 'ReactiveUI.SourceGenerators.Models'.
Updated all related using statements and namespace declarations to reflect this change.
Also updated references to ReactiveCommand and RxSchedulers in ReactiveCommandGenerator for clarity and global namespace usage.
This improves code organization and consistency across source generators.
What might this PR break?
None expected
Please check if the PR fulfills these requirements
Other information: