Skip to content

Add comparison index page.#350

Merged
ericholscher merged 9 commits intomainfrom
comparison-index
May 14, 2025
Merged

Add comparison index page.#350
ericholscher merged 9 commits intomainfrom
comparison-index

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Mar 5, 2025

This cleans up the website footer.

FIxes #234


📚 Documentation preview 📚: https://readthedocs-about--350.org.readthedocs.build/

This cleans up the website footer.
@ericholscher ericholscher requested review from a team as code owners March 5, 2025 21:34
@ericholscher ericholscher requested a review from agjohnson March 5, 2025 21:34
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@ericholscher
Copy link
Member Author

ericholscher commented Mar 28, 2025

Alright, I think I got something nicer:

Screenshot 2025-03-28 at 12 32 41 PM

I had to use explicit CSS to make the height of the images the same -- is there a way to do this with semantic UI? I wasn't sure how to target it with an external CSS file for something small like this.

@humitos
Copy link
Member

humitos commented Apr 3, 2025

I like it. The whole card is clickable now and it moves a little when you hover, which is a good visual differentiator 👍🏼

The inline CSS is a problem, tho, I'm not sure why you weren't able to use a class and put it outside the HTML. I'm sure I had a similar problem in other places already and I fixed it somehow. Maybe you can check the other files.

@humitos
Copy link
Member

humitos commented Apr 3, 2025

Found it! Yeah, actually, it's in the index file in https://github.com/readthedocs/site-community/blob/05cad1a501968b3ecabcc7450d2fff972bb470c3/content/includes/users-sphinx.html#L4-L59

he, it seems the solution was to make all the images the same height 😉 and skip using CSS... Very smart 🧠 movement, haha

@agjohnson
Copy link
Contributor

Yup, all images should be edited to be the same proportions going in.

Comment on lines 126 to 128
<div class="ui basic padded segment" style="height: 100px; display: flex; align-items: center; justify-content: center;">
<div class="ui small centered image">
<img src="{{ logo_url }}" alt="{{ logo_alt }}" style="max-height: 50px; width: auto;">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should instead edit the images to get similar proportions and alignment.

.ui.small.image already controls the size and centering of the image, inline styles or a statically sized segment shouldn't be used to dictate this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a way to edit SVG images easily. Seems like a bug in Semantic UI not being able to set an explicit height. I'm just going to merge this with offset heights, because it's better than not having it.

@ericholscher ericholscher merged commit a6b6a17 into main May 14, 2025
4 checks passed
@ericholscher ericholscher deleted the comparison-index branch May 14, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create some more top-level pages for comparisons

3 participants