fix: skip redundant_optional_initialization for @Parameter variables …#6296
Open
chetan-kmr-0607 wants to merge 1 commit intorealm:mainfrom
Open
fix: skip redundant_optional_initialization for @Parameter variables …#6296chetan-kmr-0607 wants to merge 1 commit intorealm:mainfrom
chetan-kmr-0607 wants to merge 1 commit intorealm:mainfrom
Conversation
…ealm#5884) This change updates ImplicitOptionalInitializationRule so that variables annotated with @parameter (from TipKit) are ignored when checking for redundant nil initializers. TipKit's @parameter macro requires explicitly initializing optional parameters to nil; otherwise the macro fails to expand. Without this change, the implicit_optional_initialization rule incorrectly flags these initializers, forcing developers to disable the rule. Resolves realm#5884.
SimplyDanny
requested changes
Oct 12, 2025
Collaborator
SimplyDanny
left a comment
SimplyDanny
left a comment
There was a problem hiding this comment.
Thank you for the contribution. Before this can be merged, it would need tests and a changelog entry.
Generally, I think that the attributes for which the rule shall be ignored, should be configurable instead of being hard-coded.
| @@ -1,4 +1,4 @@ | |||
| import SwiftSyntax | |||
| eimport SwiftSyntax | |||
| violations.append(ReasonedRuleViolation(position: violationPosition, reason: reason)) | ||
| // // violations.append(ReasonedRuleViolation(position: violationPosition, reason: reason)) | ||
| override func visitPost(_ node: PatternBindingSyntax) { | ||
| if let variableDecl = node.parent?.as(VariableDeclSyntax.self), |
Collaborator
There was a problem hiding this comment.
This looks a bit off.
Here's an example of your CHANGELOG entry: * fix: skip redundant_optional_initialization for @Parameter variables ….
[chetan-kmr-0607](https://github.com/chetan-kmr-0607)
[#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)note: There are two invisible spaces after the entry's text. Generated by 🚫 Danger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…(#5884)
This change updates ImplicitOptionalInitializationRule so that variables annotated with @parameter (from TipKit) are ignored when checking for redundant nil initializers. TipKit's @parameter macro requires explicitly initializing optional parameters to nil; otherwise the macro fails to expand. Without this change, the implicit_optional_initialization rule incorrectly flags these initializers, forcing developers to disable the rule.
Resolves #5884.