Fix multiline_call_arguments with enum-case patterns.#6444
Open
GandaLF2006 wants to merge 2 commits intorealm:mainfrom
Open
Fix multiline_call_arguments with enum-case patterns.#6444GandaLF2006 wants to merge 2 commits intorealm:mainfrom
GandaLF2006 wants to merge 2 commits intorealm:mainfrom
Conversation
GandaLF2006
force-pushed
the
gandalf2006/multiline_call_arguments-improve
branch
from
295f111 to
241eec6
Compare
Generated by 🚫 Danger |
GandaLF2006
force-pushed
the
gandalf2006/multiline_call_arguments-improve
branch
from
241eec6 to
2800379
Compare
GandaLF2006
force-pushed
the
gandalf2006/multiline_call_arguments-improve
branch
from
2800379 to
1cb7ca7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes false positives in multiline_call_arguments when enum-case patterns (e.g. .caseOne(...)) are used in pattern-matching positions. SwiftSyntax represents such patterns as FunctionCallExprSyntax, so the rule previously treated them as real calls and produced violations.
Problem
The rule could incorrectly lint enum-case patterns in pattern-matching constructs, e.g.:
This is a pattern, not a function call, but it was previously linted as a call expression.
Fix
We now ignore FunctionCallExprSyntax nodes only when they are located inside a pattern subtree (pattern-part only), by walking up the parent chain and checking containment within pattern containers: