Fix Nested Eager Loading on Union Types#1189
Open
alissn wants to merge 10 commits intorebing:masterfrom
Open
Conversation
Contributor
Author
|
Hi @mfn 👋, I need some help regarding interface types. In the new logic, I’m using the After changing the logic for handling
Thanks in advance for your help! 🙏 |
8d56f19 to
6cb4636
Compare
62ef432 to
f63ee9d
Compare
0159edb to
934fe4f
Compare
Contributor
Author
|
@mfn |
58d60e8 to
bc9e7ae
Compare
bc9e7ae to
cb47b32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hi,
In this pull request, I’ve added support for eager loading nested relations within Union types when using the
SelectFieldsclass.Example
Consider a scenario where you have a
Commentmodel that is morphable to bothPostandProductmodels.Each of these models has a
filerelation, and eachfilebelongs to afolder.Previously, when selecting nested relations for different Union types, the eager loading for deeper relations (like
file.folder) was ignored, leading to N+1 query issues.Reference: SelectFields.php#L254-L258
Example Query
{ comments { id title body commentable { ... on Post { id title file { id name path folder { id name } } } ... on Product { id name price file { id name path folder { id name } } } } } }In the above query, the
fileandfolderrelations for bothPostandProductmodels were not properly eager-loaded, resulting in multiple unnecessary queries.Fix
This pull request resolves the issue by leveraging Constrained Eager Loading of MorphTo Relationships, ensuring that nested relations within Union types are loaded efficiently without N+1 problems.
Type of change
Checklist
CHANGELOG.mdentryREADME.mdif neededcomposer fix-style