feat(ui): improve appearance of video player info#2474
Open
Bnyro wants to merge 1 commit intorecloudstream:masterfrom
Open
feat(ui): improve appearance of video player info#2474Bnyro wants to merge 1 commit intorecloudstream:masterfrom
Bnyro wants to merge 1 commit intorecloudstream:masterfrom
Conversation
Contributor
|
Just a FYI I have a PR after the mentioned PR with Settings to hide and other changes to video display resolution #2464 |
Contributor
Author
Anyways, it should be easy enough to rebase the other PR once one of our PRs is merged. |
Contributor
Still learning, my brain is in beta. 😎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #2454 by @phisher98.
I noticed that it's problematic that currently, there are two text views displaying video info:
This is kind of redundant.
The second issue I noticed is that the video title is as much highlighted as the playback info, i.e. they use the same text size and color. This is problematic because the video title is much more important that such meta information and thus should be visually emphasized more than these statistics that most users probably don't need that often.
(For people that don't know what I'm talking about - it's about the "Vidoza [Deutsch] - Black Mirror - ..." text at the top in the screenshots)
Screenshot on my phone:

TV layout:

Player/Trailer layout:
