Open
Conversation
During my local dev setup, I noticed that the `web-variables.env` file is gitignore'd, but Git keeps reporting it as a changed file. To avoid accidentally committing those changes, I moved the example content to a `web-variables.env.template` file (which will stay committable) and updated the development instructions to match.
Newer versions of the `postgres` image (roughly January 2020 onwards) require setting the POSTGRES_PASSWORD environment variable to be set. This changes `docker-compose.yml` to use the formerly-default password that the `web` container expects.
The current `depends_on` directives in `docker-compose.yml` are only waiting until the dependency containers start, which causes first-time setup to fail with a bunch of errors. This changes those directives to instead wait until the database service is ready for queries and that the migration step has completed sucessfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to set up a local dev environment, I ran into a few issues with the Docker Compose setup and env file.
But these changes were all I needed to get set up. The rest of the process worked great!
This PR is split into individual commits (but I wouldn't mind squashing them):
I almost committed my (test) credentials with a hasty
git commit -a!This is the dev environment fix PR that @robbielyman mentioned in #190.
I found that this started the web container with fully-applied migrations a bit more reliably with less noisy error output.
Entirely formatting. No offense taken if you drop this one!
Also, since this is my first interaction here, I want to say thanks for making and maintaining the Blaggregator! It's given me a lot of great stuff to read 😄