Fix "method redefined" warnings for sum method#46
Merged
kou merged 5 commits intored-data-tools:masterfrom Dec 24, 2025
Merged
Conversation
Member
Author
|
The reason we need to override the default |
kojix2
commented
Dec 24, 2025
kou
reviewed
Dec 24, 2025
Comment on lines
2533
to
2534
| id_builtin_enum_sum = rb_intern("__builtin_sum"); | ||
| id_builtin_ary_sum = rb_intern("__builtin_sum"); |
Member
Author
There was a problem hiding this comment.
Yeah, same method name is fine here.
kojix2
commented
Dec 24, 2025
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
kou
reviewed
Dec 24, 2025
| * to compensate the result precision when the `ary` includes Float values. | ||
| * | ||
| * Note that This library does not redefine `sum` method introduced in Ruby 2.4. | ||
| * Redefines `sum` (Ruby ≥ 2.4). Original is aliased as `__sum__`. |
Member
There was a problem hiding this comment.
Let's use ASCII.
Suggested change
| * Redefines `sum` (Ruby ≥ 2.4). Original is aliased as `__sum__`. | |
| * Redefines `sum` (Ruby >= 2.4). Original is aliased as `__sum__`. |
| * to compensate the result precision when the `enum` includes Float values. | ||
| * | ||
| * Note that This library does not redefine `sum` method introduced in Ruby 2.4. | ||
| * Redefines `sum` (Ruby ≥ 2.4). Original is aliased as `__sum__`. |
Member
There was a problem hiding this comment.
Suggested change
| * Redefines `sum` (Ruby ≥ 2.4). Original is aliased as `__sum__`. | |
| * Redefines `sum` (Ruby >= 2.4). Original is aliased as `__sum__`. |
Member
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43
Hello.
This PR addresses the issue in #43.
__sum__for Enumerable and Array.