[chore] Updating orchestrator npm packages to OCI artifacts#307
[chore] Updating orchestrator npm packages to OCI artifacts#307OpinionatedHeron wants to merge 8 commits intoredhat-developer:mainfrom
Conversation
Signed-off-by: Leanne Ahern <lahern@redhat.com>
Signed-off-by: Leanne Ahern <lahern@redhat.com>
Signed-off-by: Leanne Ahern <lahern@redhat.com>
|
/cherry-pick release-1.9 |
|
@rm3l: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
charts/backstage/values.yaml
Outdated
| - disabled: false | ||
| package: "https://npm.registry.redhat.com/@redhat/backstage-plugin-orchestrator-backend-dynamic/-/backstage-plugin-orchestrator-backend-dynamic-1.8.2.tgz" | ||
| package: "oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-orchestrator-backend:bs_1.45.3__8.3.0!red-hat-developer-hub-backstage-plugin-orchestrator-backend" | ||
| integrity: sha512-6G0YguzCM5nCDpOrIGJpLTXVMr6EBdIVqSXtsLH9RvBH25RTuFpfJ7q6eEp26DqveaiqUCfBpJ51smdjcsEzFQ== |
There was a problem hiding this comment.
| integrity: sha512-6G0YguzCM5nCDpOrIGJpLTXVMr6EBdIVqSXtsLH9RvBH25RTuFpfJ7q6eEp26DqveaiqUCfBpJ51smdjcsEzFQ== |
Same point as in redhat-developer/rhdh-operator#2231 (comment)
There was a problem hiding this comment.
hmm. since DPDY has the community-built refs for orchestrator, maybe we need a new rule in the script that generates the DPDY so that if the plugin is
- TP or GA supported, and
- exists in quay.io
we use the quay.io/rhdh reference instead of the ghcr.io one.
https://github.com/redhat-developer/rhdh/blob/main/dynamic-plugins.default.yaml#L1346-L1358
WDYT?
There was a problem hiding this comment.
Is this the scope of https://issues.redhat.com/browse/RHIDP-11725?
Also, I guess we would need to handle the different tagging logic (like bs_1.45.3__5.1.0 in ghcr.io vs 1.9.0--5.1.0 in quay.io)..
As I commented out above, I think we should leverage the {{inherit}} option in the install methods to inherit the version and config from the DPDY, otherwise it will quickly become a nightmare to keep up with the versions.
But for this to work properly, we should use the same reference as in the DPDY.
So as soon as we switch to quay.io/rhdh reference in the DPDY, we should update the install methods here accordingly.
This option is supported as of RHDH 1.9 and allows inheriting the version from the dynamic-plugins.default.yaml (coming from the plugin catalog index image). This way, we are sure to use the default plugin version. NOTE: For this to work properly, the plugin refs should match. So if the orchestrator plugins refs are changed later to quay.io or registry.access.redhat.com in the DPDY, we should update them here as well.
|
/review |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Signed-off-by: Leanne Ahern <lahern@redhat.com>
Signed-off-by: Leanne Ahern <lahern@redhat.com>
charts/backstage/values.yaml
Outdated
| - disabled: false | ||
| package: "https://npm.registry.redhat.com/@redhat/backstage-plugin-orchestrator-backend-dynamic/-/backstage-plugin-orchestrator-backend-dynamic-1.8.2.tgz" | ||
| integrity: sha512-6G0YguzCM5nCDpOrIGJpLTXVMr6EBdIVqSXtsLH9RvBH25RTuFpfJ7q6eEp26DqveaiqUCfBpJ51smdjcsEzFQ== | ||
| - package: 'oci://quay.io/rhdh/red-hat-developer-hub-backstage-plugin-orchestrator-backend:{{ "{{" }}inherit{{ "}}" }}' |
There was a problem hiding this comment.
| - package: 'oci://quay.io/rhdh/red-hat-developer-hub-backstage-plugin-orchestrator-backend:{{ "{{" }}inherit{{ "}}" }}' | |
| - package: 'oci://registry.access.redhat.com/rhdh/red-hat-developer-hub-backstage-plugin-orchestrator-backend:{{ "{{" }}inherit{{ "}}" }}' |
Sorry for the back-and-forth on this. As discussed on https://redhat-internal.slack.com/archives/C06SGFD65NC/p1770127827110089, we can directly use the registry.access.redhat.com reference, and ensure we can transparently pull to quay.io/rhdh automatically (https://issues.redhat.com/browse/RHIDP-11773).
But for this to work with {{inherit}}, the dynamic-plugins.default.yaml file needs to have the same OCI reference. This will be the scope of https://redhat-internal.slack.com/archives/C06SGFD65NC/p1770141534032199?thread_ts=1770127827.110089&cid=C06SGFD65NC
So can you change the refs to registry.access.redhat.com, but we would need to wait until the catalog index image is updated accordingly.
Thanks.
/hold
Signed-off-by: Leanne Ahern <lahern@redhat.com>
|
4 participants
Description of the change
Updating orchestrator npm packages to the relevant OCI Artifacts to reflect updates to RHDH.
npm packages were causing the scaffolder plugin to throw an error during startup
Which issue(s) does this PR fix or relate to
RHDHBUGS-2527
How to test changes / Special notes to the reviewer
Deploy Helm-based instance of RHDH with the orchestrator plugins enabled.
Checklist
Chart.yamlaccording to Semantic Versioning.values.yamland added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Usepre-commit run -ato apply changes. The pre-commit Workflow will do this automatically for you if needed.pre-commithook.ct lintcommand.