fix: resolve metadata validation failures

[polasudo]

https://issues.redhat.com/browse/RHDHBUGS-2574

Description of problem:

Version metadata for plugin, packages and dynamicArtifact is mismatched.

Mismatches can be viewed here: https://github.com/redhat-developer/rhdh-plugin-export-overlays/actions/runs/21521471288/job/62013576902

[imykhno]

I am not sure if it's part of this PR, however I want to share that I noticed. Some of .yaml use old supportedVersions version. For example, for the adoption-insights version was updated to 1.45.2 - ref.
Should the version also be updated in the PR?

[gashcrumb]

Hmm, yes on a given rhdh release we would want this to match the backstage version. @polasudo I wonder this field could probably be set automatically couldn't it?

[dzemanov]

This would be good to update. However, only for plugins that are on that Backstage version. I think that if some plugins are on older Backstage version, they would need to be manually validated that they work.

[polasudo]

@gashcrumb best thing would be to update it but the I am not exactly sure why they are not updated, while other are updated, maybe the problem is that they are not build for higher versions of backstage ?

[dzemanov]

Some are not updated because it was forgotten. Some are not updated because they are on older backstage version then 1.45. On the other hand, looking at catalog for 1.8, looks like all of the plugins there had supportedVersions set to 1.42, even if they were on different version. E.g roadie jira https://github.com/redhat-developer/rhdh/blob/release-1.8/catalog-entities/marketplace/packages/roadiehq-backstage-plugin-jira.yaml#L21 is on 1.40.2: https://github.com/RoadieHQ/roadie-backstage-plugins/blob/main/plugins/frontend/backstage-plugin-jira/CHANGELOG.md#2131, but supportedVersions are set to 1.42: https://github.com/redhat-developer/rhdh/blob/release-1.8/catalog-entities/marketplace/packages/roadiehq-backstage-plugin-jira.yaml#L24

[dzemanov]

I have updated supportedVersions for plugins that are on that version.
Let me know if we want to update all of them.
Remaining ones should be:

  Roadie Backstage Plugins (8 plugins)
  1. roadiehq-backstage-plugin-argo-cd-backend.yaml
  2. roadiehq-scaffolder-backend-module-http-request.yaml
  3. roadiehq-scaffolder-backend-module-utils.yaml
  4. roadiehq-scaffolder-backend-argocd.yaml
  5. roadiehq-backstage-plugin-security-insights.yaml
  6. roadiehq-backstage-plugin-jira.yaml
  7. roadiehq-backstage-plugin-github-pull-requests.yaml
  8. roadiehq-backstage-plugin-github-insights.yaml
  9. roadiehq-backstage-plugin-datadog.yaml
  Red Hat Resource Optimization (2 plugins)
  1. redhat-resource-optimization.yaml
  2. redhat-resource-optimization-backend.yaml
  AWS Plugins (2 plugins)
  1. aws-amazon-ecs-plugin-for-backstage.yaml
  2. aws-amazon-ecs-plugin-for-backstage-backend.yaml
  PagerDuty Plugins (2 plugins)
  1. pagerduty-backstage-plugin.yaml
  2. pagerduty-backstage-plugin-backend.yaml
  Immobiliarelabs Plugins (2 plugins)
  1. immobiliarelabs-backstage-plugin-gitlab.yaml
  2. immobiliarelabs-backstage-plugin-gitlab-backend.yaml
  Parfuemerie Plugins (1 plugin)
  1. parfdg-scaffolder-backend-mod-azure-repositories.yaml

[nickboldt]

@josephca didn't we delete a bunch of that from the overlays repo?

[dzemanov]

Thank you so much @polasudo!
/lgtm
/approve

[github-actions]

⚠️
Test workflow skipped: PR doesn't touch exactly one workspace.

[nickboldt]

See also related PR #1929

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[dzemanov]

/lgtm
/approve

[polasudo]

/publish

[polasudo]

/lgtm
/approve

[openshift-ci]

@polasudo: you cannot LGTM your own PR.

Details

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dzemanov, gashcrumb, polasudo

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[github-actions]

PR action (/publish) cancelled: PR doesn't touch only 1 workspace.

issues has been fixed

[github-actions]

⚠️
Test workflow skipped: PR doesn't touch exactly one workspace.

[dzemanov]

/cherry-pick release-1.9

[openshift-cherrypick-robot]

@dzemanov: #1915 failed to apply on top of branch "release-1.9":

Applying: fix: resolve metadata validation failures
Using index info to reconstruct a base tree...
A	workspaces/apiconnect/metadata/apic-backstage-plugin.yaml
A	workspaces/dynatrace-dql/metadata/dynatrace-backstage-plugin-dql-backend.yaml
A	workspaces/dynatrace-dql/metadata/dynatrace-backstage-plugin-dql.yaml
Falling back to patching base and 3-way merge...
Auto-merging workspaces/dynatrace/metadata/backstage-community-plugin-dynatrace.yaml
CONFLICT (content): Merge conflict in workspaces/dynatrace/metadata/backstage-community-plugin-dynatrace.yaml
CONFLICT (modify/delete): workspaces/dynatrace-dql/metadata/dynatrace-backstage-plugin-dql-backend.yaml deleted in HEAD and modified in fix: resolve metadata validation failures. Version fix: resolve metadata validation failures of workspaces/dynatrace-dql/metadata/dynatrace-backstage-plugin-dql-backend.yaml left in tree.
CONFLICT (modify/delete): workspaces/apiconnect/metadata/apic-backstage-plugin.yaml deleted in HEAD and modified in fix: resolve metadata validation failures. Version fix: resolve metadata validation failures of workspaces/apiconnect/metadata/apic-backstage-plugin.yaml left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 fix: resolve metadata validation failures

Details

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dzemanov]

Note: cherry-pick failed because some workspaces were removed for release-1.9 branch in this commit: 6d81ca9, workspaces removed:

• acs
• apiconnect
• aws-ecs
• dynatrace-dql
• mta
• openshift-image-registry
• redhat-resource-optimization
• scaffolder-backend-module-azure-repositories
• tech-insights