fix: default value with special chars with anyOf#963
Open
p-spacek wants to merge 7 commits intoredhat-developer:mainfrom
Open
fix: default value with special chars with anyOf#963p-spacek wants to merge 7 commits intoredhat-developer:mainfrom
p-spacek wants to merge 7 commits intoredhat-developer:mainfrom
Conversation
p-spacek
added a commit
to jigx-com/rh-yaml-language-server
that referenced
this pull request
May 2, 2024
p-spacek
commented
May 2, 2024
| let value = propertySchema.default || propertySchema.const; | ||
| if (value) { | ||
| if (type === 'string') { | ||
| let value = propertySchema.default === undefined ? propertySchema.const : propertySchema.default; |
Contributor
Author
There was a problem hiding this comment.
fixes condition to allow null,0,emptyString as a default or const
the same logic is correctly used in other places
| return this.getInsertTextForValue(value, separatorAfter, type); | ||
| } | ||
|
|
||
| private getInsertTextForPlainText(text: string): string { |
Contributor
Author
There was a problem hiding this comment.
moved outside of the class to be able to use it from global functions
p-spacek
added a commit
to jigx-com/rh-yaml-language-server
that referenced
this pull request
May 2, 2024
Contributor
|
@p-spacek please rebase the repo |
8672460 to
2675e84
Compare
2675e84 to
26ec17a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This schema
doesn't escape default value
note that an object with anyOf (engine) needs to be inside another object (car), then getInserTextForObject is called with schema { car: {engine: anyOf}}
What issues does this PR fix or reference?
no ref
Is it tested? How?
unit-test