Open
Conversation
https://quay.io/repository/opct/opct/manifest/sha256:0cb8605376c996718c1f17ae9546a9995e3a697330b9dbfd3d9bb4115664ef0e?tab=vulnerabilities&fixable=true GHSA-jc7w-c686-c4v9 <!-- - Please ensure code changes are split into a series of logically independent commits. - Every commit should have a subject/title (What) and a description/body (Why). - Every PR must have a description. - As an example you can use git commit -m"What" -m"Why" to achieve the requirements above. GitHub automatically recognizes the commit description (-m"Why") in single commit PRs and adds it as the PR description. - Use the [imperative mood](https://en.wikipedia.org/wiki/Imperative_mood) in the subject line for every commit. E.g `Mark infraID as required` instead of `This patch marks infraID as required` (This follows Git’s own built-in conventions). See openshift/hypershift#485 as an example. - See https://github.com/redhat-openshift-ecosystem/opct/blob/main/CONTRIBUTING.md for more details. Delete this text before submitting the PR. --> **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, use `fixes #<issue_number>(, fixes #<issue_number>, ...)` format, where issue_number might be a GitHub issue, or a Jira story*: Fixes # **Checklist** - [ ] Subject and description added to both, commit and PR. - [x] Relevant issues have been referenced. - [ ] This change includes docs. - [ ] This change includes unit tests.
…200) ## Summary This PR updates CLAUDE.md to reflect lessons learned from the v0.6.1 release process and removes references to the broken auto-release-tag workflow. ## Changes **Removed**: - `Improved PR-Based Release Workflow` section (lines 854-1082) - References to `.github/workflows/auto-release-tag.yaml` from release checklist - Automated tag creation workflow file (already deleted in main) **Updated**: - Release checklist to reflect manual tag creation process - Last Updated date to 2025-12-08 **Added**: - **Lessons Learned from v0.6.1 Release** section documenting: - What went wrong: Automated workflow issues, golangci-lint-action@v7 compatibility - What worked: Manual tags, rebase workflow, plugin releases - Key takeaways: Keep it simple, don't change what works - Recommended approach: Manual tag creation - **What's Next** section with: - Short-term improvements (fix golangci-lint, standardize formats) - Medium-term improvements (CI stability, version management) - Long-term opportunities (release tooling, testing, documentation) - Anti-patterns to avoid based on v0.6.1 experience ## Rationale The auto-release-tag workflow proved unreliable during v0.6.1 release: - Complex workflow was difficult to debug when it failed - Failed silently when PR description didn't match expected format - Required specific PR format that was easy to forget - Blocked release for several hours during troubleshooting Manual tag creation is: - Simple and predictable - Easy to troubleshoot - Provides full control over changelog content - Works consistently for both CLI and Plugins repositories For infrequent tasks like releases (~monthly), manual processes are more maintainable than complex automation. ## Testing - [x] CLAUDE.md follows existing formatting standards - [x] All auto-release-tag references removed - [x] Manual release process documented clearly - [x] Lessons learned capture key issues and solutions 🤖 Claude Code Assistant --------- Co-authored-by: Claude <noreply@anthropic.com>
**What this PR does / why we need it**: The changes introduced in this PR documents the **current valid** scenarios for users applying to VCSP. Recommendations must be aligned with PTAM and Program manager. Added decision tree to the User Guide to ensure users are installing correctly. <img width="774" height="1221" alt="Screenshot From 2025-10-27 13-35-59" src="https://github.com/user-attachments/assets/d8759f86-512e-4649-8a1c-4b0ad524ae37" /> **Which issue(s) this PR fixes** *(optional, use `fixes #<issue_number>(, fixes #<issue_number>, ...)` format, where issue_number might be a GitHub issue, or a Jira story*: Fixes # **Checklist** - [ ] Subject and description added to both, commit and PR. - [ ] Relevant issues have been referenced. - [ ] This change includes docs. - [ ] This change includes unit tests.
**What this PR does / why we need it**: Set the boundaries of supported version based in the current issue blocking validations 4.20+ described in https://issues.redhat.com/browse/OCPBUGS-77783 **Which issue(s) this PR fixes** *(optional, use `fixes #<issue_number>(, fixes #<issue_number>, ...)` format, where issue_number might be a GitHub issue, or a Jira story*: Fixes # **Checklist** - [ ] Subject and description added to both, commit and PR. - [ ] Relevant issues have been referenced. - [ ] This change includes docs. - [ ] This change includes unit tests.
**What this PR does / why we need it**: Enhance version command with more details about the environment, including plugins image versions and cluster version. Enhancing version command to improve the stdout, specially when assets isn't collected: ~~~sh $ make build-linux-amd64 GOOS=linux GOARCH=amd64 go build -o /home/me/go/src/github.com/mtulio/opct/build/opct-linux-amd64 -ldflags '-s -w -X github.com/redhat-openshift-ecosystem/opct/pkg/version.commit=b1b2642f -X github.com/redhat-openshift-ecosystem/opct/pkg/version.version=0.0.0' /home/me/go/src/github.com/mtulio/opct $ ./build/opct-linux-amd64 version OPCT CLI: 0.0.0+b1b2642f Images versions: sonobuoy:v0.57.3 (library v0.57.3) plugin-openshift-tests:v0.6.1 plugin-artifacts-collector:v0.6.1 must-gather-monitoring:v0.6.1 Cluster version: unknown (KUBECONFIG is not set) $ make build-linux-amd64 RELEASE_TAG=1.0.0 GOOS=linux GOARCH=amd64 go build -o /home/me/go/src/github.com/mtulio/opct/build/opct-linux-amd64 -ldflags '-s -w -X github.com/redhat-openshift-ecosystem/opct/pkg/version.commit=b1b2642f -X github.com/redhat-openshift-ecosystem/opct/pkg/version.version=1.0.0' /home/me/go/src/github.com/mtulio/opct $ ./build/opct-linux-amd64 version OPCT CLI: 1.0.0 Images versions: sonobuoy:v0.57.3 (library v0.57.3) plugin-openshift-tests:v0.6.1 plugin-artifacts-collector:v0.6.1 must-gather-monitoring:v0.6.1 Cluster version: unknown (KUBECONFIG is not set) $ export KUBECONFIG=$HOME/openshift/deploy/install-dir-v7/auth/kubeconfig $ ./build/opct-linux-amd64 version OPCT CLI: 1.0.0 Images versions: sonobuoy:v0.57.3 (library v0.57.3) plugin-openshift-tests:v0.6.1 plugin-artifacts-collector:v0.6.1 must-gather-monitoring:v0.6.1 Cluster version: OpenShift: 4.22.0-ec.2 Kubernetes: v1.34.2 ~~~ **Which issue(s) this PR fixes** *(optional, use `fixes #<issue_number>(, fixes #<issue_number>, ...)` format, where issue_number might be a GitHub issue, or a Jira story*: Fixes # **Checklist** - [x] Subject and description added to both, commit and PR. - [ ] Relevant issues have been referenced. - [ ] This change includes docs. - [ ] This change includes unit tests.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Collaborator
Author
|
We dont want to squash, we want to rebsae and cherry pick commits. |
openshift-ci
bot
added
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)format, where issue_number might be a GitHub issue, or a Jira story:Fixes #
Checklist