Skip to content

Add data validation, fix test_tools#48

Open
dvalinrh wants to merge 4 commits intomainfrom
add_validation
Open

Add data validation, fix test_tools#48
dvalinrh wants to merge 4 commits intomainfrom
add_validation

Conversation

@dvalinrh
Copy link
Contributor

@dvalinrh dvalinrh commented Feb 4, 2026

Description

  1. Verifies the data results
  2. Handles test_tools in an agreed on standard way.
  3. Renames results.csv to be results_passmark.csv

Before/After Comparison

Before: Data was not verified
After: data is verified

Clerical Stuff

This closes #47

Relates to JIRA: RPOPC-817

Testing
Command executed
/home/ec2-user/workloads/passmark-wrapper-2.5/passmark/passmark_run --run_user ec2-user --home_parent /home --iterations 1 --tuned_setting tuned_none_sys_file_ --host_config "m5.xlarge" --sysname "m5.xlarge" --sys_type aws --use_pcp --iterations 5 --debug

induced error (just 1 line shown)
0.Operations
Input should be a valid number, unable to parse string as a number [type=float_parsing, input_value='badbeef', input_type=str]
For further information visit https://errors.pydantic.dev/2.12/v/float_parsing

csv file
estname,Operations,Start_Date,End_Date
CPU_INTEGER_MATH,11335.362999999999,2026-02-04T15:41:44Z,2026-02-04T15:44:16Z
CPU_FLOATINGPOINT_MATH,6082.1457346839197,2026-02-04T15:41:44Z,2026-02-04T15:44:16Z
CPU_PRIME,26.122437077424117,2026-02-04T15:41:44Z,2026-02-04T15:44:16Z
CPU_SORTING,6087.46516491906,2026-02-04T15:41:44Z,2026-02-04T15:44:16Z
CPU_ENCRYPTION,1564.8990616192859,2026-02-04T15:41:44Z,2026-02-04T15:44:16Z
CPU_COMPRESSION,50263.877745766629,2026-02-04T15:41:44Z,2026-02-04T15:44:16Z
CPU_SINGLETHREAD,1809.320120741997,2026-02-04T15:41:44Z,2026-02-04T15:44:16Z
CPU_PHYSICS,506.25538611254166,2026-02-04T15:41:44Z,2026-02-04T15:44:16Z
CPU_MATRIX_MULT_SSE,2976.9006672378405,2026-02-04T15:41:44Z,2026-02-04T15:44:16Z
CPU_mm,341.32895078381932,2026-02-04T15:41:44Z,2026-02-04T15:44:16Z
CPU_sse,1244.1632237234335,2026-02-04T15:41:44Z,2026-02-04T15:44:16Z
CPU_fma,3659.3867334371766,2026-02-04T15:41:44Z,2026-02-04T15:44:16Z
CPU_avx,2588.2840004347054,2026-02-04T15:41:44Z,2026-02-04T15:44:16Z
CPU_avx512,4415.7687113560478,2026-02-04T15:41:44Z,2026-02-04T15:44:16Z
m_CPU_enc_SHA,512678046.52800316,2026-02-04T15:41:44Z,2026-02-04T15:44:16Z
m_CPU_enc_AES,3954287052.0498819,2026-02-04T15:41:44Z,2026-02-04T15:44:16Z
m_CPU_enc_ECDSA,455781696.731628,2026-02-04T15:41:44Z,2026-02-04T15:44:16Z
ME_ALLOC_S,1374.5511128342177,2026-02-04T15:41:44Z,2026-02-04T15:44:16Z
ME_READ_S,22246.063085937501,2026-02-04T15:41:44Z,2026-02-04T15:44:16Z
ME_READ_L,11670.06640625,2026-02-04T15:41:44Z,2026-02-04T15:44:16Z
ME_WRITE,10291.3896484375,2026-02-04T15:41:44Z,2026-02-04T15:44:16Z
ME_LARGE,12366,2026-02-04T15:41:44Z,2026-02-04T15:44:16Z
ME_LATENCY,52.064480400582163,2026-02-04T15:41:44Z,2026-02-04T15:44:16Z
ME_THREADED,25913.30322265625,2026-02-04T15:41:44Z,2026-02-04T15:44:16Z
SUMM_CPU,4002.4775705839511,2026-02-04T15:41:44Z,2026-02-04T15:44:16Z
SUMM_ME,2137.1207164651623,2026-02-04T15:41:44Z,2026-02-04T15:44:16Z

pcp snippet

      o.w.iteration  o.w.running  o.w.numthreads  o.w.runtime  o.w.throughput  o.w.latency  o.w.CPU_INTEGER_MATH  o.w.CPU_FLOATINGPOINT_MATH  o.w.CPU_PRIME  o.w.CPU_SORTING  o.w.CPU_ENCRYPTION  o.w.CPU_COMPRESSION  o.w.CPU_SINGLETHREAD  o.w.CPU_PHYSICS  o.w.CPU_MATRIX_MULT_SSE  o.w.CPU_mm  o.w.CPU_sse  o.w.CPU_fma  o.w.CPU_avx  o.w.CPU_avx512  o.w.m_CPU_enc_SHA  o.w.m_CPU_enc_AES  o.w.m_CPU_enc_ECDSA  o.w.ME_ALLOC_S  o.w.ME_READ_S  o.w.ME_READ_L  o.w.ME_WRITE  o.w.ME_LARGE  o.w.ME_LATENCY  o.w.ME_THREADED  o.w.SUMM_CPU  o.w.SUMM_ME

15:44:18 5.000 1.000 0.000 NaN NaN NaN 11325.494 6083.961 26.206 6011.772 1566.228 49956.746 1801.267 530.059 2968.811 343.944 1244.351 3664.723 2575.308 4390.861 512801072.296 3957067323.430 457058129.417 1367.305 22225.573 11742.704 10465.462 12365.000 52.374 26302.286 3997.299 2140.298
15:44:19 5.000 1.000 0.000 NaN NaN NaN 11325.494 6083.961 26.206 6011.772 1566.228 49956.746 1801.267 530.059 2968.811 343.944 1244.351 3664.723 2575.308 4390.861 512801072.296 3957067323.430 457058129.417 1367.305 22225.573 11742.704 10465.462 12365.000 52.374 26302.286 3997.299 2140.298

--debug
passmark_out.txt

@dvalinrh dvalinrh requested a review from kdvalin February 4, 2026 16:16
@kdvalin
Copy link
Member

kdvalin commented Feb 4, 2026

Wrong Jira ticket

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

This relates to RPOPC-817

@dvalinrh dvalinrh requested a review from kdvalin February 4, 2026 22:33
kdvalin
kdvalin previously approved these changes Feb 5, 2026
Copy link
Member

@kdvalin kdvalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@redhat-performance redhat-performance deleted a comment from github-actions bot Feb 5, 2026
Copy link
Member

@kdvalin kdvalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

using pyantics, add test validation

2 participants