couchbase: add counter operations increment and decrement#3818
Open
sapk wants to merge 4 commits intoredpanda-data:mainfrom
Open
couchbase: add counter operations increment and decrement#3818sapk wants to merge 4 commits intoredpanda-data:mainfrom
sapk wants to merge 4 commits intoredpanda-data:mainfrom
Conversation
334e332 to
424f811
Compare
424f811 to
11e4110
Compare
Contributor
Author
|
I updated the PR to have the ttl support also on increment and decrement operations since #3825 was merged. I also change to require and enforce that content is a valid integer. Previously any invalid or empty value set the delta to zero meaning a noop but it had the bad design of silencing error. Also I simply return the error in process batch but maybe I could be more subtle and attach the error on the message and skip adding it to the ops list. |
Contributor
|
At least this feature is available in the other implementation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add atomic counter operations support for Couchbase processor.
This is backward compatible as they are new operations.
Note: This might conflict with #2709 but I can rebase over the first to be merged.