Skip to content

Add Email Confirmation Dialog to Prevent Signup Typos #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
LuisCusihuaman wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add Email Confirmation Dialog to Prevent Signup Typos #198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
99 changes: 62 additions & 37 deletions src/components/SignupPage/SignupForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ type State = {
success: boolean,
universities: Array<any>,
studentId: string,
confirmEmailOpen: boolean,
};

class Signup extends React.Component<Props, State> {
Expand All @@ -64,6 +65,7 @@ class Signup extends React.Component<Props, State> {
success: false,
universities: [],
studentId: "",
confirmEmailOpen: false,
};

componentDidMount() {
Expand Down Expand Up @@ -91,52 +93,60 @@ class Signup extends React.Component<Props, State> {

handleSignUpClick(event) {
event.preventDefault();
const {
username,
email,
password,
name,
surname,
degree,
university,
studentId: student_id,
error,
} = this.state;

if (error.invalidFields.size !== 0 || !university || !degree) {
this.setState(prevState => ({
error: {
open: true,
message: "El formulario cuenta con campos invalidos",
invalidFields: prevState.error.invalidFields,
},
}));
return;
}
this.setState({ confirmEmailOpen: true });
}

authenticationService
.signup({
handleConfirmEmail(confirm) {
if (confirm) {
const {
username,
email,
password,
name,
surname,
degree,
university: university && university.name,
student_id,
})
.then(() => {
this.setState({ success: true });
})
.catch(() => {
this.setState({
university,
studentId: student_id,
error,
} = this.state;

if (error.invalidFields.size !== 0 || !university || !degree) {
this.setState(prevState => ({
error: {
open: true,
message: "Hubo un error de sign up, revisa que los datos ingresados sean validos.",
invalidFields: new Set(),
message: "El formulario cuenta con campos invalidos",
invalidFields: prevState.error.invalidFields,
},
}));
return;
}

authenticationService
.signup({
username,
email,
password,
name,
surname,
degree,
university: university && university.name,
student_id,
})
.then(() => {
this.setState({ success: true });
})
.catch(() => {
this.setState({
error: {
open: true,
message: "Hubo un error de sign up, revisa que los datos ingresados sean validos.",
invalidFields: new Set(),
},
});
});
});
}

this.setState({ confirmEmailOpen: false });
}

canSignUp() {
Expand Down Expand Up @@ -170,7 +180,7 @@ class Signup extends React.Component<Props, State> {

render() {
const { classes, history } = this.props;
const { error, success, universities, university } = this.state;
const { error, success, universities, university, confirmEmailOpen, email } = this.state;

return (
<div>
Expand All @@ -183,7 +193,7 @@ class Signup extends React.Component<Props, State> {
>
<DialogTitle id="alert-dialog-title">Valida tu email</DialogTitle>
<DialogContent>
<DialogContentText id="alert-dialog-description">
<DialogContentText id="alert-dialog-description">
Revisá tu bandeja de entrada y seguí las instrucciones en el email. Puede tardar unos
minutos en llegar.
</DialogContentText>
Expand All @@ -198,6 +208,21 @@ class Signup extends React.Component<Props, State> {
</DialogActions>
</Dialog>

<Dialog open={confirmEmailOpen}>
<DialogTitle>Confirmación de Email</DialogTitle>
<DialogContent>
<DialogContentText>¿Estás seguro de que este es tu correo: {email}?</DialogContentText>
</DialogContent>
<DialogActions>
<Button onClick={() => this.handleConfirmEmail(false)} color="primary">
Cancelar
</Button>
<Button onClick={() => this.handleConfirmEmail(true)} color="primary">
Confirmar
</Button>
</DialogActions>
</Dialog>

<Typography component="h1" variant="h5">
Sign Up
</Typography>
Expand Down