Conversation
|
There is at least one "real" use of this library, acid-store. If this were merged it should be done so with a major version bump to prevent breakages. |
|
(Pinging the aforementioned crate's author in case they have any comments - @lostatc) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6
This changes the ZPAQ parameters to match the official ZPAQ C++ lib's implementations.
Of course it causes the hashes and the chunks to be different and is therefore a breaking change. In addition, it still doesn't match the official implementation exactly, since it has specific limits on the chunk sizes as well, which are optional here.
I do not know if it is worth making this change, I am filing this for completeness. On the other hand, the deviations from the official implementation should be documented.