-
Notifications
You must be signed in to change notification settings - Fork 11
replayio browser command uses agent-browser to puppet replay browser #643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Caution Review the following alerts detected in dependencies. According to your organization's Security Policy, you must resolve all "Block" alerts before proceeding. It is recommended to resolve "Warn" alerts too. Learn more about Socket for GitHub.
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "scripts": { | ||
| "build": "pkg-build", | ||
| "lint": "prettier --write .", | ||
| "postinstall": "node ./scripts/apply-agent-browser-patches.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
postinstall scripts might get aggressively blocked by package managers - this package really shouldn't depend on them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you summarize what this PR and what the patch is meant to accomplish here? From what I see agent-browser supports custom browser executables already. Can't this package just piggyback on that? What else is missing?
Uh oh!
There was an error while loading. Please reload this page.