Skip to content

chore: upgraded eslint to v9 and configure typescript compatible rules#280

Open
nafees87n wants to merge 10 commits intomasterfrom
fix/eslint
Open

chore: upgraded eslint to v9 and configure typescript compatible rules#280
nafees87n wants to merge 10 commits intomasterfrom
fix/eslint

Conversation

@nafees87n
Copy link
Contributor

@nafees87n nafees87n commented Feb 2, 2026

Summary by CodeRabbit

  • Chores
    • Updated Node.js requirement to 20.20.0.
    • Replaced legacy ESLint setup with a modern flat-style configuration and updated ESLint packages.
    • Added JS/TS linting improvements and global ignore patterns consolidation.
    • Adjusted TypeScript compiler options (skipLibCheck enabled) for more consistent builds.

@coderabbitai
Copy link

coderabbitai bot commented Feb 2, 2026

Walkthrough

Replaces legacy ESLint configuration and ignore file with a Flat Config setup: adds eslint.config.js and removes .eslintrc.js and .eslintignore. Updates ESLint and related devDependencies in package.json and adds the globals package. Bumps Node target in .nvmrc from 16.15.0 to 20.20.0. Updates tsconfig.json to add skipLibCheck and exclude node_modules. Removes several ESLint disable comments in three source files. No functional application logic was introduced.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main changes: upgrading ESLint to v9 and configuring TypeScript-compatible rules as evidenced by the package.json (ESLint ^9.39.2), eslint.config.js (new FlatCompat configuration), and TypeScript-related configuration updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/eslint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nafees87n nafees87n requested a review from nsrCodes February 2, 2026 15:06
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Fix all issues with AI agents
In @.nvmrc:
- Line 1: Update the README.md Node.js version reference from 16.15.0 to match
.nvmrc (20.20.0): find the line in README.md that mentions "Node.js 16.15.0" and
replace it with "Node.js 20.20.0" and optionally add a short note to reference
the .nvmrc file as the authoritative runtime version.

In `@eslint.config.js`:
- Around line 35-37: Remove the undefined "prettier/prettier" rule from the
rules object in eslint.config.js (the entry currently set to "off") because
eslint-plugin-prettier is not installed; either delete that rule line from the
rules block or, if you prefer to keep it, add eslint-plugin-prettier to
devDependencies and register it in the flat config so the "prettier/prettier"
rule is available.
- Line 33: The config currently assigns compat.extends(...) to an extends
property inside a config object (see usage of compat.extends in
eslint.config.js), but FlatCompat returns an array that must be spread into the
top-level config array; fix by removing the extends property from those config
objects and instead spread ...compat.extends(...) directly into the exported
top-level array where other config entries live (apply the same change for both
occurrences of compat.extends at the two locations).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants