Fix tests to be compatible with urllib3 2.0#356
Fix tests to be compatible with urllib3 2.0#356pquentin wants to merge 2 commits intorequests:masterfrom
Conversation
46ed438 to
63408fa
Compare
63408fa to
7202405
Compare
|
The urllib3 2.0 tests are fixed by urllib3/urllib3#2998 |
|
Is the company issue in the toolbelt or in betamax? |
|
What is the company issue sorry? If you mean urllib3/urllib3#2999 it's a totally different issue |
|
*compatibility If rerecording the cassettes makes a difference it makes me think the compatibility problem is in Betamax fundamentally |
|
Maybe it is. I don't know, I have to admit I stuck with the first thing that worked. But I did not have to change most responses, so this is definitely fishy. I would have to investigate more and understand how Betamax works. |
|
patches from this pull are needed for tests to pass on master branch when using urllib3 2.0. I have a yocto setups and I can confirm the failures without these patches. |
|
Thanks for confirming! However I'm not sure the approach is correct and still works on 1.26.x. We would have to fix our CI to tell. |
Somehow some cassette files were incompatible. I also tried adding urllib3 2.0 tests in CI, let's see how that goes.