Open
Conversation
Author
|
On second thought, this shouldn't be merged before reshape/#75 is merged & published because this project depends on it, which would make the update incomplete. |
jescalan
approved these changes
Apr 19, 2019
Member
jescalan
left a comment
jescalan
left a comment
There was a problem hiding this comment.
LGTM - as you suggested let's wait on #75 then we can get this shipped out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did a highly overdue update of the dependencies, fixing all npm security warnings.
Everything went pretty smoothly, except when npm generated my
package-lock.jsonwrong. That definitely did not cost me 30 minutes of "where is this dependency coming from?"...I had to add the spaces between the braces in
test/index.jsto make the tests pass again, probably due to some linter being updated.(this obviously makes #18 and #19 obsolete)