Default quiet=false when background with logfile

[meatballhat]

Closes #565

[meatballhat]

@xeron How's this? 😸

[xeron]

Well, it may help, but the whole situation raises some questions.

• Why do you have different behavior in background/foreground mode?
• Why do you have 2 variables controlling logging – VERBOSE and QUIET?
  • It's confusing
  • Seems like you don't respect VERBOSE in background mode? Or in both bg/fg modes?

I see this code in logger builder:

      def level
        if @verbose && !@quiet
          MonoLogger::DEBUG
        elsif !@quiet
          MonoLogger::INFO
        else
          MonoLogger::FATAL
        end
      end

but looks like in background mode you're using some different logic?

[meatballhat]

@xeron I agree that the current situation with verbose and quiet is confusing. Legacy code! (and some recent changes)

My understanding of the current intent, is:

default_quiet = false

if options[:background]
  default_quiet = true
end

if options[:logfile]
  default_quiet = false
end

log_level = if options.fetch(:quiet, default_quiet)
              FATAL
            elsif options.fetch(:verbose, false)
              DEBUG
            else
              INFO
            end

I'm very much ready to believe that the current implementation does not match this intent. Supporting explicit log levels instead of the verbose / quiet thing sounds great to me, assuming that's what you're suggesting 😸

[xeron]

Yeah, I think keeping only logfile and loglevel is better. But this is up to you. With explanation of what QUIET / VERBOSE actually do it's a bit cleaner for me now (if it works as you described).

[xeron]

Soo, what happened to this PR and issue I reported? This bug still affects me :(

[bolsen]

I started using resque-scheduler and am noticing the same issue that @xeron is reporting here. Is there a workaround at least so we can get logs?