add a railtie to load rescue scheduler automatically in rails apps#694
Open
josh-m-sharpe wants to merge 1 commit intoresque:masterfrom
Open
add a railtie to load rescue scheduler automatically in rails apps#694josh-m-sharpe wants to merge 1 commit intoresque:masterfrom
josh-m-sharpe wants to merge 1 commit intoresque:masterfrom
Conversation
iloveitaly
requested changes
Sep 15, 2021
Contributor
iloveitaly
left a comment
iloveitaly
left a comment
There was a problem hiding this comment.
Thanks for this! Could you:
- Rebase on master so CI runs
- Add a note to the changelog
- Update the readme?
Thanks!
| require_relative 'scheduler/signal_handling' | ||
| require_relative 'scheduler/failure_handler' | ||
|
|
||
| require 'resque/scheduler/railtie' if defined?(Rails) |
Contributor
There was a problem hiding this comment.
Based on the issue that came up in resque I think we need to do
Suggested change
| require 'resque/scheduler/railtie' if defined?(Rails) | |
| require 'resque/scheduler/railtie' if defined?(Rails::Railtie) |
Right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should eliminate some basic boilerplating.