Skip to content

[WIP] Implement Cancel restart/Kill restart feature#2348

Closed
slinkydeveloper wants to merge 8 commits intorestatedev:mainfrom
slinkydeveloper:issues/895-second-attempt
Closed

[WIP] Implement Cancel restart/Kill restart feature#2348
slinkydeveloper wants to merge 8 commits intorestatedev:mainfrom
slinkydeveloper:issues/895-second-attempt

Conversation

@slinkydeveloper
Copy link
Contributor

Fix #895. Depends on #2335

The fundamental commit where semantics are implements is this one: 0edc593

Essentially the behavior is the following:

  • Cancel and Kill behaviors are left untouched
  • If the "restart" option is enabled when cancelling/killing, at the end of the invocation the state machine will simply reset the in flight invocation status, removing the pinned deployment id and resetting the journal (except the first entry, that is the input entry)

This commit exposes the feature both in Admin API and in CLI

@slinkydeveloper slinkydeveloper force-pushed the issues/895-second-attempt branch from 53e2e64 to fef23e4 Compare December 6, 2024 09:17
@slinkydeveloper
Copy link
Contributor Author

slinkydeveloper commented Dec 9, 2024

We talked offline about:

  • Make sure if you cancel and retry, and then subsequently kill, then kill takes precedence and no retry takes place (to do in this PR) DONE
  • Introduce something like "k8s resource event log" for invocation status with start/finished/retried events (in a followup) WILL DO IN IMMUTABLE JOURNAL

@slinkydeveloper slinkydeveloper changed the title Implement Cancel restart/Kill restart feature [WIP] Implement Cancel restart/Kill restart feature May 26, 2025
@slinkydeveloper
Copy link
Contributor Author

At this point, this is outdated and we don't need it anymore. It's mostly superseded by #3360

@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cancel/Kill and retry invocation from Admin API

1 participant